This repository has been archived by the owner on May 6, 2024. It is now read-only.
Observations in 'glyphs', 'inv_glyphs' now fixed to correspond to description of an object class instead of the name of object class. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
heiner
approved these changes
Jun 23, 2021
win/rl/winrl.cc
Outdated
| inventory_.emplace_back( | ||
| rl_inventory_item{ obj_to_glyph(otmp, rn2_on_display_rng), | ||
| rl_inventory_item{ shuffled_glyph(glyph), |
There was a problem hiding this comment.
It's fine to do shuffled_glyph(obj_to_glyph(otmp, rn2_on_display_rng)).
description of an object class instead of the name of object class. Prior to this commit, the glyph id for a 'Scroll of Identify' always had the same id. After this commit, the glyph id for a scroll called 'KERNOD_WELL' always has the same id. This mirrors the behaviour of tiles, for builds that use them.
cdmatters
force-pushed
the
eric/fix-glyphs
branch
from
0a263e7 to
65f2a5c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the glyph id for a 'Scroll of Identify' always had the same id.
After this commit, the glyph id for a scroll called 'KERNOD_WELL' always has the same id.
This mirrors the behaviour of tiles (for builds that use them).