Change _reward_fn to take action taken #166
Conversation
|
Hi @RobertKirk! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -194,7 +196,7 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| super().__init__(*args, options=options, **kwargs) | |||
|
|
|||
| def _reward_fn(self, last_observation, observation, end_status): | |||
| def _reward_fn(self, last_observation, action, observation, end_status): | |||
| """Difference between previous gold and new gold.""" | |||
| del end_status # Unused | |||
There was a problem hiding this comment.
Thanks! To keep this in line with how this code was written so far, would you mind adding del action lines to make linters happy about action not being used in these functions at this point?
There was a problem hiding this comment.
Sure thing, I've made that change
In standard RL often the reward function takes as input the action taken. This change allows that to happen by adjusting _reward_fn. See issue facebookresearch#155 for more details
RobertKirk
force-pushed
the
reward-fn-action
branch
from
4f404ab to
59a473e
Compare
In standard RL often the reward function takes as input the action
taken. This change allows that to happen by adjusting _reward_fn.
See issue #155 for more details
Closes #155