Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Rerange tty_colors to [0, 32) #142

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Rerange tty_colors to [0, 32) #142

merged 1 commit into from
Dec 14, 2020

Conversation

tscmoo
Copy link
Contributor

@tscmoo tscmoo commented Dec 13, 2020

tty_colors had an unusual range perhaps intended to be [-16, 16), but ended up being... something strange.
This changes it to be [0, 32).
Seeing as nothing really uses this yet, it should be safe to change.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2020
@heiner heiner self-requested a review December 14, 2020 12:20
heiner
heiner approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@heiner heiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tscmoo tscmoo merged commit 19509c0 into master Dec 14, 2020
@tscmoo tscmoo deleted the moo/rearrange-tty-colors branch December 14, 2020 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@heiner heiner heiner approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tscmoo @heiner @facebook-github-bot