Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Added architecture document and links in README.md. #127

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

cdmatters
Copy link
Contributor

@cdmatters cdmatters commented Nov 13, 2020

Added the architecture document that was found on Quip. It maybe more helpful to view the rendered version for reviewing purposes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2020
Copy link
Contributor

@heiner heiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only suggestion would be:

(1) To move this file into doc/nle, and
(2) To reference it from README.md.

I'd like to avoid adding too many files to the root directory.

@heiner
Copy link
Contributor

heiner commented Nov 16, 2020

Ah (2) is basically happening here, albeit with an extra link in between. We can probably link your document directly?

Copy link
Contributor

@heiner heiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdmatters cdmatters merged commit d94e1fa into master Nov 18, 2020
@cdmatters cdmatters deleted the eric/architecture branch November 18, 2020 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants