This repository has been archived by the owner on May 6, 2024. It is now read-only.
Fix extra newline at end of NLE run; fix fwrite when bz2 is disabled. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
yobibyte
approved these changes
Nov 6, 2020
| @@ -77,7 +77,7 @@ write_data(void *buf, int length) | |||
| BZ2_bzWrite(&bzerror, nle->ttyrec_bz2, buf, length); | |||
| assert(bzerror == BZ_OK); | |||
| #else | |||
| assert(fwrite(buf, 1, length, nle->ttyrec) == 0); | |||
| assert(fwrite(buf, 1, length, nle->ttyrec) == length); | |||
There was a problem hiding this comment.
Can you explain this line to me?
There was a problem hiding this comment.
This fixes a mistake I made earlier: fwrite doesn't signal an OK status with 0, it returns the number of bytes written when everything went well.
This code path is only active when NLE_BZ2_TTYRECS is not defined, which I did to test out this change as it allows to use nle-ttyplay -p.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.