Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Use same running Python version in CMake. #116

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Use same running Python version in CMake. #116

merged 1 commit into from
Nov 10, 2020

Conversation

heiner
Copy link
Contributor

@heiner heiner commented Nov 5, 2020

In some rare cases, CMake can insist on using a different Python
version than the one that runs setup.py at the moment. This change
should prevent that.

In some rare cases, CMake can insist on using a different Python
version than the one that runs setup.py at the moment. This change
should prevent that.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2020
@heiner heiner requested a review from cdmatters November 5, 2020 21:31
Copy link
Contributor

@cdmatters cdmatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine, but I would consider using the Python version of sysconfig, which I assume does the same. The Python documentation seems to encourage people to discourage direct use of distutils...

@heiner heiner merged commit 6e65a61 into master Nov 10, 2020
@heiner heiner deleted the update-cmake branch November 10, 2020 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants