This repository has been archived by the owner on May 6, 2024. It is now read-only.
Fix a bad memory leak. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out I misunderstood what pybind11's py::array::ensure does. Looking at the code superficially (https://github.com/pybind/pybind11/blob/master/include/pybind11/numpy.h#L785) I assumed this function steals a reference, hence the call to release(). But the reference is being stolen from the return value of raw_array(), which returns a new reference. Hence ensure() itself does not steal anything but in fact increases the refcount (and will decref it in ~array). Thanks to Vitaly Kurin for both finding this issue and insisting that it happens on the Python side (I thought this might be related to malloc calls in NetHack itself).
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out I misunderstood what pybind11's py::array::ensure does.
Looking at the code superficially (https://github.com/pybind/pybind11/blob/master/include/pybind11/numpy.h#L785)
I assumed this function steals a reference, hence the call to
release(). But the reference is being stolen from the return value
of raw_array(), which returns a new reference. Hence ensure() itself
does not steal anything but in fact increases the refcount (and will
decref it in ~array).
Thanks to @yobibyte for both finding this issue and insisting that
it happens on the Python side (I thought this might be related to
malloc calls in NetHack itself).