Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Don't call setbuf on stdout in NLE #113

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Don't call setbuf on stdout in NLE #113

merged 2 commits into from
Nov 4, 2020

Conversation

heiner
Copy link
Contributor

@heiner heiner commented Nov 4, 2020 •
edited
Loading

Should fix #112.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2020
Don't call setbuf on stdout in NLE.
d3baee1 
This should fix a bug relating to readline (#112).
@heiner heiner requested review from yobibyte and cdmatters November 4, 2020 12:30
yobibyte
yobibyte reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@yobibyte yobibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure how this works, but shouldn't we do the same on line 147, when we declare obuf? static char obuf[BUFSIZ]; /* BUFSIZ is defined in stdio.h */

@heiner
Copy link
Contributor Author

heiner commented Nov 4, 2020

I'm not entirely sure how this works, but shouldn't we do the same on line 147, when we declare obuf? static char obuf[BUFSIZ]; /* BUFSIZ is defined in stdio.h */

Fair question. Changed that one too.

@heiner heiner changed the title Don't call setbuf on stdin in NLE Don't call setbuf on stdout in NLE Nov 4, 2020
@heiner heiner merged commit 9a8115e into master Nov 4, 2020
@heiner heiner deleted the bug-hotfix branch November 4, 2020 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yobibyte yobibyte yobibyte approved these changes

@cdmatters cdmatters Awaiting requested review from cdmatters

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive Python crashes when two environments are started in a certain way
3 participants
@heiner @yobibyte @facebook-github-bot