Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add TELEPORT to non-RL actions. #101

Merged
merged 4 commits into from
Nov 2, 2020
Merged

Add TELEPORT to non-RL actions. #101

merged 4 commits into from
Nov 2, 2020

Conversation

yobibyte
Copy link
Contributor

No description provided.

@yobibyte yobibyte requested a review from heiner October 23, 2020 16:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2020
@heiner
Copy link
Contributor

heiner commented Oct 27, 2020

I'm fine to put this in for now but note that there's other ways of getting the "select something on the screen" type of input (e.g., higher-level versions of fireball, cone of cold, and even more likely short-term, scrolls of stinking cloud).

It's probably a better idea to try to detect this situation in particular.

@yobibyte
Copy link
Contributor Author

Agree with the general approach, but not sure if this is the priority now and if we are anywhere close to use those.

Copy link
Contributor

@heiner heiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's squash-commit this as I don't think we want or need the history in this case.

@yobibyte yobibyte merged commit bddca73 into master Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants