[PR on PR] Fix constraints #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jrapin
commented
Mar 15, 2021
nevergrad/optimization/base.py
Outdated
Comment on lines
444
to
447
| max_trials_ask = max_trials | ||
| if self.budget is not None: # dont use too much internal optimizer budget for this | ||
| # this update is probably pointless though, since the budget will be consumed and we may use too much budget anyway | ||
| max_trials_ask = max(1, min(max_trials, (self.budget - self.num_ask) // 2)) |
There was a problem hiding this comment.
@teytaud actually I am not sure what this solves at all, for one shot optimizers it will just change nothing and fail anyway :s
jrapin
commented
Mar 15, 2021
| @@ -523,7 +523,7 @@ def _ellips(x: np.ndarray) -> float: | |||
| "penalization,expected,as_layer", | |||
| [ | |||
| (False, [1.005573e00, 3.965783e-04], False), | |||
| (True, [1.000001, 0.002842], False), | |||
| (True, [0.999924, -0.111009], False), | |||
There was a problem hiding this comment.
notice that it deteriorates the results, because it runs only 5 trials now instead of around 50 at the beginning
jrapin
commented
Mar 15, 2021
| @@ -523,7 +523,7 @@ def _ellips(x: np.ndarray) -> float: | |||
| "penalization,expected,as_layer", | |||
| [ | |||
| (False, [1.005573e00, 3.965783e-04], False), | |||
| (True, [1.000001, 0.002842], False), | |||
| (True, [0.999924, -0.111009], False), | |||
There was a problem hiding this comment.
notice that it deteriorates the results, because it runs only 5 trials now instead of around 50 at the beginning
jrapin
commented
Mar 15, 2021
Comment on lines
-438
to
-440
| self._constraints_manager.max_trials // 2 | ||
| if self.budget is None | ||
| else (self.budget - self.num_ask), |
There was a problem hiding this comment.
this really had unexpected behaviors since it completely ignores max_trials
jrapin
commented
Mar 16, 2021
teytaud
added a commit
that referenced
this pull request
Mar 17, 2021
* cst_solver * warning * warning * fix * black * fix keras issue * Update test_mlfunctionlib.py * black * [PR on cstsolve PR] Try to extract constraint solving (#968) * returnpenalties * fix * removeprints * extract Co-authored-by: Jeremy Rapin <jrapin@fb.com> * Update utils.py * Fix a bug. The previous code was ok only if the optimization method is not limited by the budget. * Update base.py * fix * fix * Update base.py * Update base.py * Update base.py * fix * fix * fix * fix_comment * fixes * black * fix * fix * fix_typo * Update nevergrad/optimization/base.py Co-authored-by: Jérémy Rapin <jrapin.github@gmail.com> * Update nevergrad/optimization/base.py * Clarify suggest arguments (#1072) * Skip rocket xp test for speed (#1075) * Update parametrization flatten function (#1074) * Add configuration for PSO + simplifications (#1073) * Remove deprecated stuff (#1041) * fix keras issue * Update test_mlfunctionlib.py * black * remove_useless_stuff * Update test_core.py * fix * Update core.py * Morphing with Nevergrad (#1042) * fix keras issue * Update test_mlfunctionlib.py * black * WIP morphing * fix * Update core.py * black * fix * fix * syntax_fix * fix * fix * fix * fix * fix * black * Update core.py * Update core.py * Add MOO xp variants (#1004) * MOO variants * Update experiments.py * better_alignment * better_doc * fix * minor * fix * CHANGELOG * black * fix * [PR on PR] Fix constraints (#1079) Co-authored-by: Jeremy Rapin <jrapin@fb.com> Co-authored-by: Jérémy Rapin <jrapin.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist