This repository was archived by the owner on Oct 31, 2023. It is now read-only.
modify senario where dataset has no mask provided #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
fmassa
reviewed
May 24, 2019
| masks = [obj["segmentation"] for obj in anno] | ||
| masks = SegmentationMask(masks, img.size, mode='poly') | ||
| target.add_field("masks", masks) | ||
| masks = [obj["segmentation"] for obj in anno if any(obj["segmentation"])] |
There was a problem hiding this comment.
maybe you could just add something similar to what is done for keypoints just below?
if anno and 'segmentation' in anno[0]:
# rest of the code here
There was a problem hiding this comment.
Hi,
Thanks for this suggestion, I have modified the code as the keypoint part. Please add more comments if further modification is required.
Lyears
pushed a commit
to Lyears/maskrcnn-benchmark
that referenced
this pull request
Jun 28, 2020
* modify senario where dataset has no mask provided * change to check segmentation mask in the way of keypoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As reported in this issue, when there is no
segmentationfield in the json file (which I believe will be quite common in practice, since most people would like to use this codebase in the bbox detection task), there will be a error ofindex out of rangein theboxlistindexing operations. I feel maybe this modification would allow to get rid of this error by not adding the filed ofmaskto thebboxlistobject.I am not sure whether this modification is in consistent with the designing spirit of this repo. If it is not proper to implement this modification, please let me know and I will delete this pr so that we can discuss another place where I feel maybe a little modification will make it better :)