Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

keep the resize function the same in test time the same with training time #798

Merged
merged 1 commit into from
May 24, 2019

Conversation

hcx1231
Copy link
Contributor

@hcx1231 hcx1231 commented May 20, 2019

The result may be affected when the implementation of resize function in inference time and training time is inconsistent,so I changed the code in inference time to keep them same.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 20, 2019
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fmassa
Copy link
Contributor

fmassa commented May 24, 2019

The only difference I see is that the images might be larger than 1333 pixels, but is this a problem?

@hcx1231
Copy link
Contributor Author

hcx1231 commented May 24, 2019

The only difference I see is that the images might be larger than 1333 pixels, but is this a problem?

Yes,when the images are very large,for example in my own dataset,it may cause large error as it haven't been trained in such size,which took me several weeks to find out this problem.

@fmassa
Copy link
Contributor

fmassa commented May 24, 2019

Ok, fair enough.

@fmassa fmassa merged commit 3d2e2b3 into facebookresearch:master May 24, 2019
Lyears pushed a commit to Lyears/maskrcnn-benchmark that referenced this pull request Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants