Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Update defaults.py #774

Merged
merged 1 commit into from
May 24, 2019
Merged

Update defaults.py #774

merged 1 commit into from
May 24, 2019

Conversation

zhangliliang
Copy link
Contributor

remove _C.MODEL.BACKBONE.USE_GN = False in config/defaults.py, since it is not used in the code.

liliang@liliang-ubuntu:~/liliang_learning/maskrcnn-benchmark/maskrcnn_benchmark$ grep -r "USE_GN"
Binary file config/__pycache__/defaults.cpython-37.pyc matches
config/defaults.py:_C.MODEL.BACKBONE.USE_GN = False
config/defaults.py:_C.MODEL.FPN.USE_GN = False
config/defaults.py:_C.MODEL.ROI_BOX_HEAD.USE_GN = False
config/defaults.py:_C.MODEL.ROI_MASK_HEAD.USE_GN = False
Binary file modeling/backbone/__pycache__/backbone.cpython-37.pyc matches
modeling/backbone/backbone.py:            cfg.MODEL.FPN.USE_GN, cfg.MODEL.FPN.USE_RELU
modeling/backbone/backbone.py:            cfg.MODEL.FPN.USE_GN, cfg.MODEL.FPN.USE_RELU
Binary file modeling/roi_heads/mask_head/__pycache__/roi_mask_feature_extractors.cpython-37.pyc matches
modeling/roi_heads/mask_head/roi_mask_feature_extractors.py:        use_gn = cfg.MODEL.ROI_MASK_HEAD.USE_GN
Binary file modeling/roi_heads/box_head/__pycache__/roi_box_feature_extractors.cpython-37.pyc matches
modeling/roi_heads/box_head/roi_box_feature_extractors.py:        use_gn = cfg.MODEL.ROI_BOX_HEAD.USE_GN
modeling/roi_heads/box_head/roi_box_feature_extractors.py:        use_gn = cfg.MODEL.ROI_BOX_HEAD.USE_GN

remove `_C.MODEL.BACKBONE.USE_GN = False`, since it is not used in the code.

```
liliang@liliang-ubuntu:~/liliang_learning/maskrcnn-benchmark/maskrcnn_benchmark$ grep -r "USE_GN"
Binary file config/__pycache__/defaults.cpython-37.pyc matches
config/defaults.py:_C.MODEL.BACKBONE.USE_GN = False
config/defaults.py:_C.MODEL.FPN.USE_GN = False
config/defaults.py:_C.MODEL.ROI_BOX_HEAD.USE_GN = False
config/defaults.py:_C.MODEL.ROI_MASK_HEAD.USE_GN = False
Binary file modeling/backbone/__pycache__/backbone.cpython-37.pyc matches
modeling/backbone/backbone.py:            cfg.MODEL.FPN.USE_GN, cfg.MODEL.FPN.USE_RELU
modeling/backbone/backbone.py:            cfg.MODEL.FPN.USE_GN, cfg.MODEL.FPN.USE_RELU
Binary file modeling/roi_heads/mask_head/__pycache__/roi_mask_feature_extractors.cpython-37.pyc matches
modeling/roi_heads/mask_head/roi_mask_feature_extractors.py:        use_gn = cfg.MODEL.ROI_MASK_HEAD.USE_GN
Binary file modeling/roi_heads/box_head/__pycache__/roi_box_feature_extractors.cpython-37.pyc matches
modeling/roi_heads/box_head/roi_box_feature_extractors.py:        use_gn = cfg.MODEL.ROI_BOX_HEAD.USE_GN
modeling/roi_heads/box_head/roi_box_feature_extractors.py:        use_gn = cfg.MODEL.ROI_BOX_HEAD.USE_GN
```
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not!

@fmassa fmassa merged commit 2ff23c4 into facebookresearch:master May 24, 2019
Lyears pushed a commit to Lyears/maskrcnn-benchmark that referenced this pull request Jun 28, 2020
remove `_C.MODEL.BACKBONE.USE_GN = False`, since it is not used in the code.

```
liliang@liliang-ubuntu:~/liliang_learning/maskrcnn-benchmark/maskrcnn_benchmark$ grep -r "USE_GN"
Binary file config/__pycache__/defaults.cpython-37.pyc matches
config/defaults.py:_C.MODEL.BACKBONE.USE_GN = False
config/defaults.py:_C.MODEL.FPN.USE_GN = False
config/defaults.py:_C.MODEL.ROI_BOX_HEAD.USE_GN = False
config/defaults.py:_C.MODEL.ROI_MASK_HEAD.USE_GN = False
Binary file modeling/backbone/__pycache__/backbone.cpython-37.pyc matches
modeling/backbone/backbone.py:            cfg.MODEL.FPN.USE_GN, cfg.MODEL.FPN.USE_RELU
modeling/backbone/backbone.py:            cfg.MODEL.FPN.USE_GN, cfg.MODEL.FPN.USE_RELU
Binary file modeling/roi_heads/mask_head/__pycache__/roi_mask_feature_extractors.cpython-37.pyc matches
modeling/roi_heads/mask_head/roi_mask_feature_extractors.py:        use_gn = cfg.MODEL.ROI_MASK_HEAD.USE_GN
Binary file modeling/roi_heads/box_head/__pycache__/roi_box_feature_extractors.cpython-37.pyc matches
modeling/roi_heads/box_head/roi_box_feature_extractors.py:        use_gn = cfg.MODEL.ROI_BOX_HEAD.USE_GN
modeling/roi_heads/box_head/roi_box_feature_extractors.py:        use_gn = cfg.MODEL.ROI_BOX_HEAD.USE_GN
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants