Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix INSTALL.md #510

Merged
merged 3 commits into from
Mar 5, 2019
Merged

fix INSTALL.md #510

merged 3 commits into from
Mar 5, 2019

Conversation

bmetge
Copy link
Contributor

@bmetge bmetge commented Feb 28, 2019

-> don't need the pytorch nightly
-> not enforcing cuda 9.0
-> using torchvision
-> reorder so the pip install -r requirement.txt comes after clone and not before

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

fmassa
fmassa reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I have a few comments, let me know what you think

INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
@fmassa fmassa mentioned this pull request Feb 28, 2019
Open
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 28, 2019
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

fmassa
fmassa reviewed Mar 1, 2019
View reviewed changes
INSTALL.md Show resolved Hide resolved
fmassa
fmassa approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit de42d89 into facebookresearch:master Mar 5, 2019
@ghost
Copy link

ghost commented Mar 11, 2019

had a problem about the pycoco stuff and need to install pip3 install Cython first.

@fmassa fmassa mentioned this pull request Mar 11, 2019
Merged
@fmassa
Copy link
Contributor

fmassa commented Mar 11, 2019

@estimoelmo yes, you are right, this patch here is broken because pycocotools require cython.

I'll revert those changes, and update the readme to point to pytorch nightly

@fmassa fmassa mentioned this pull request Mar 11, 2019
Merged
Lyears pushed a commit to Lyears/maskrcnn-benchmark that referenced this pull request Jun 28, 2020
@bmetge @fmassa
fix INSTALL.md (facebookresearch#510)
43345f4 
* fix INSTALL.md

* fix PR

* Update INSTALL.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chengyangfu chengyangfu chengyangfu left review comments

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmetge @facebook-github-bot @fmassa @chengyangfu