clarifying directory structure and fixing typo #448
Conversation
A few addition: I added the top level directory `cityscapes` since the `tools/cityscapes/convert_cityscapes_to_coco.py` script has the directory structure `gtFine_trainvaltest/gtFine` hardcoded into it which is fine but was not clear at first. Also added a **Note** to warn people to install detectron as well, since the script uses `detectron.utils.boxes` and `detectron.utils.segm` modules which has further dependencies in the detectron lib.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| ``` | ||
| 3. Run the below commands to convert the annotations | ||
| **NOTE: Detectron AND maskrcnn_benchmark is required** |
There was a problem hiding this comment.
This sounds good to me, but from a glance at the implementation, it is really easy to get rid of the dependency on Detectron.
There was a problem hiding this comment.
Lazily I have copied boxes.py and segms.py from detectron to the maskrcnn utils, but then I saw that in boxes there was another level of dependency - and I got like "meh... just quickly install detectron", but then I had to resolve the caffe2 stuff :D so yeah... what would you suggest?
I can trace all the functions back in the detectron lib and copy them together to the maskrcnn lib or follow along #447
There was a problem hiding this comment.
I think you should follow what I've mentioned in #447. There is really only one function that needs to be ported from Detectron, the other is already in this repo. Let me know if you have further questions!
A few addition: I added the top level directory `cityscapes` since the `tools/cityscapes/convert_cityscapes_to_coco.py` script has the directory structure `gtFine_trainvaltest/gtFine` hardcoded into it which is fine but was not clear at first. Also added a **Note** to warn people to install detectron as well, since the script uses `detectron.utils.boxes` and `detectron.utils.segm` modules which has further dependencies in the detectron lib.
A few addition:
I added the top level directory
cityscapessince thetools/cityscapes/convert_cityscapes_to_coco.pyscript has the directory structuregtFine_trainvaltest/gtFinehardcoded into it which is fine but was not clear at first.Also added a Note to warn people to install detectron as well, since the script uses
detectron.utils.boxesanddetectron.utils.segmmodules which has further dependencies in the detectron lib.