Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix tqdm usage #246

Merged
merged 1 commit into from
Dec 5, 2018
Merged

fix tqdm usage #246

merged 1 commit into from
Dec 5, 2018

Conversation

CoinCheung
Copy link
Contributor

Maybe this is the behavior that the authors would like to see, I guess.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 4, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fmassa
Copy link
Contributor

fmassa commented Dec 4, 2018

Is there a difference?

@CoinCheung
Copy link
Contributor Author

I think so. On my platform of archlinux with python3.7, the following two pieces of code behaves differently (one has process bar, while the other does not).

from tqdm import tqdm
s = 1
for i, n in enumerate(tqdm(range(100000))):
    s += i
from tqdm import tqdm
s = 1
for i, n in tqdm(enumerate(range(100000))):
    s += i

@fmassa
Copy link
Contributor

fmassa commented Dec 5, 2018

Oh, I see the difference now, thanks.

While this change would be ok, the fact that we use tqdm here is purely because I didn't bother changing it to a more logging-friendly approach back then.

While having the progress bar would be nice, it would also clutter much more some logs.
Anyway, I think we can merge this and remove the usage of tqdm later on.

Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 46dbf29 into facebookresearch:master Dec 5, 2018
Ricardozzf added a commit to Ricardozzf/maskrcnn-benchmark that referenced this pull request Dec 11, 2018
nprasad2021 pushed a commit to nprasad2021/maskrcnn-benchmark that referenced this pull request Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants