Dockerfile with jupyter notebook support

[keineahnung2345]

Hello,
In this PR, I add support to jupyter notebook, so that one can program from remote.
To make this work, one needs to run the image with nvidia-docker run -td -p 8888:8888 -e PASSWORD=<password> maskrcnn-benchmark-jupyter, in which one sets the password which is used by jupyter notebook. And then one can go to localhost:8888 and start programming.

I put the 3 repos(vision, cocoapi, maskrcnn-benchmark) inside the newly added folder "/notebooks", tell me if it needs to be changed.

[fmassa]

cc @miguelvr as I don't know much about Dockerfiles

[miguelvr]

I never used jupyter notebooks inside a docker container tbh... is there really a need for this?

[keineahnung2345]

@miguelvr I agree it's optional. But with it, one can use his own browser to program and don't need to go into the docker and then use vim to do the same thing.

[fmassa]

I'm ok with merging this, but as I mentioned before I'm not super familiar with Docker so it would be good if someone else could review this.

[miguelvr]

@miguelvr I agree it's optional. But with it, one can use his own browser to program and don't need to go into the docker and then use vim to do the same thing.

you don't have necessarily to go into the docker and use vim... you can mount directories, use solutions like pycharm, etc.

But sure, it is a nice option to have.

I just have one question: why is the password thing necessary?

[keineahnung2345]

@miguelvr Because I am using a Linux server(without GUI) from remote, so I can't use IDE like pycharm or spyder. And it should be the easiest way for me.

The password is used by jupyter noetbook. If we don't set a password for jupyter notebook, it will generate a random token when it (automatically) start for safe's sake. And you will need to key in that token when you open :8888 in your browser. But since we let jupyter notebook start automatically inside docker container, it will be hard to find out what the token is. And using password just avoids the need of finding out the token.

[miguelvr]

@miguelvr Because I am using a Linux server(without GUI) from remote, so I can't use IDE like pycharm or spyder. And it should be the easiest way for me.

I am too, and yes it is possible :)

The password is used by jupyter noetbook. If we don't set a password for jupyter notebook, it will generate a random token when it (automatically) start for safe's sake. And you will need to key in that token when you open :8888 in your browser. But since we let jupyter notebook start automatically inside docker container, it will be hard to find out what the token is. And using password just avoids the need of finding out the token.

Cool, got it! LGTM

[fmassa]

@miguelvr can approve the PR once you are good with it? I'll merge once you approve

[soumith]

there’s nothing special about the jupyter notebook config to warrant bringing the tensorflow copyright. just rewrite the few lines, they are trivial

addressed

[keineahnung2345]

@fmassa Could you please merge this PR now?

[fmassa]

Thanks!