Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Docker hotfix #162

Merged
merged 7 commits into from
Nov 16, 2018
Merged

Docker hotfix #162

merged 7 commits into from
Nov 16, 2018

Conversation

miguelvr
Copy link
Contributor

The argument names where being overridden by the CUDA image env variables, resulting in a failure in the NCCL2 installation.

This fixes the issue

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 16, 2018
@miguelvr miguelvr changed the title Docker hotfix [WIP] Docker hotfix Nov 16, 2018
@miguelvr
Copy link
Contributor Author

removed the explicit install of NCCL2, as it was creating problems and it comes installed in the nvidia/cuda image

@miguelvr miguelvr changed the title [WIP] Docker hotfix Docker hotfix Nov 16, 2018
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 2fbb8dd into facebookresearch:master Nov 16, 2018
nprasad2021 pushed a commit to nprasad2021/maskrcnn-benchmark that referenced this pull request Jan 29, 2019
* added Dockerfile

* intructions for installation with docker

* INSTALL.md: added note to inform nvidia-docker only works with Linux

* dockerfile nccl2 hotfix

* INSTALL.md update

* removes explicit install of NCCL2 as it is included in the CUDA image
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants