replacing dtype torch.uint8 with torch.bool for indexing in pytorch 1.2.0

[garycao-cv]

Indexing with dtype torch.uint8 is deprecated in pytorch 1.2.0. Current version generates lots of warnings like "/opt/conda/conda-bld/pytorch_1565272271120/work/aten/src/ATen/native/IndexingUtils.h:20: UserWarning: indexing with dtype torch.uint8 is now deprecated, please use a dtype torch.bool instead."
In this PR, dtype torch.uint8 is replaced with torch.bool for indexing in compliance with pytorch 1.2.0.

[botcs]

Hey @garycao-cv thanks for the PR
Could you please compare your version with #1093 ? There are some extra additions as well. If there are some differences please make a PR to that feature branch and I'll merge it.

Make sure all tests are passing and COCO R50 FPN scores can be reproduced, using the weight file from model zoo

[garycao-cv]

Thanks @botcs.
All tests passed. When I tried to create a PR targeting your feature branch, I could not find your repo/feature branch in the target box. Is your branch open to PRs? or did I miss anything here?
Thanks.

[botcs]

Did you try it here? https://github.com/botcs/maskrcnn-benchmark/pulls

[garycao-cv]

@botcs Yes, I tried. Still could not target your branch for creating a PR. I'm attaching two screen shots here to show you what I saw on my side by following the link you shared. (PR-step2 is what I got after I clicked the "New Pull Request" in PR-step1)

PR-step1.pdf
PR-step2.pdf

[garycao-cv]

@botcs any thoughts? Could you see if you can create a PR on your side to merge my changes into your branch? Thanks.

[botcs]

ummm. on the second image, botcs is on the list...

So please try again on this link: botcs/maskrcnn-benchmark@pytorch-v1.2...botcs:pytorch-v1.2 but please select your head branch (the box on the right)

[garycao-cv]

@botcs thanks for the response. But I'm quite confused by it. On the second image, there are five repos on the list after I type bo, which are facebookresearch, Bowenbao, Designbook1, aabobakr, Imsreborn. Is there an alias for botcs or I'm really missing something here. Thanks again for looking into this.

[garycao-cv]

@botcs I can see botcs on the list of the right (i.e. source repo), but not on the list of the left (i.e. target repo). That's why I thought there may be some special setting on your side. Can you see your repo in the list of the left box?

[botcs]

closing my PR

[garycao-cv]

@botcs thanks for taking care of this!