Fix int full key when deep copying in instantiate #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jesszzzz
requested review from
andywag,
Sanjay-Ganeshan,
hstonec and
tonykao8080
jesszzzz
force-pushed
the
fix_int_full_key
branch
from
2a53d55 to
e29eefe
Compare
tonykao8080
reviewed
Feb 3, 2025
| @@ -151,8 +151,9 @@ def _deep_copy_full_config(subconfig: Any) -> Any: | |||
| return copy.deepcopy(subconfig) | |||
|
|
|||
| full_key = subconfig._get_full_key(None) | |||
| if not full_key: | |||
| if full_key == "" or full_key is None: | |||
There was a problem hiding this comment.
I think the new condition is the same as not full_key. is there a specific scenario you cannot use not full_key?
There was a problem hiding this comment.
Oh yeah that's another bug I forgot to mention in the summary, if it's the first item of a list, full_key is 0 so we can't use not full_key
jesszzzz
force-pushed
the
fix_int_full_key
branch
from
e29eefe to
da5849b
Compare
michaelriedl
pushed a commit
to michaelriedl/hydra
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Was seeing an error like this when the full config is a list:
This fixes it by typecasting to a string, and adds a test to avoid future instances
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
new unittest passes
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)