Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack to fix security issue #2941

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Update webpack to fix security issue #2941

merged 1 commit into from
Sep 3, 2024

Conversation

jesszzzz
Copy link
Contributor

@jesszzzz jesszzzz commented Aug 29, 2024

Motivation

Updating webpack dependency with fix to the security issue: https://github.com/webpack/webpack/security/advisories/GHSA-4vvj-4cpr-p986?fbclid=IwZXh0bgNhZW0CMTEAAR2VZBw7fKoTndY3K5jqXYGozNY-_pl49j2E4_4e090uhLwF7ErvvImieFo_aem_nrF-sqME9iivAjihdd1X1A

and micromatch dependency to fix the security issue:
https://github.com/advisories/GHSA-952p-6rrq-rcjv?fbclid=IwZXh0bgNhZW0CMTEAAR3_18LZj5-bqxrI_Xq0a7gxpynmOkCXfki3hOPzgyKGiN_s8uRNsBUNJgw_aem_vlt_WpArcasNIsFDLrxxMw

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Ran yarn start and verified the website still loads successfully

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2024
Copy link

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jesszzzz jesszzzz merged commit 08ff298 into main Sep 3, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants