Fix CI tests #2921
Merged
Fix CI tests #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
omry
reviewed
Jul 15, 2024
plugins/hydra_ray_launcher/integration_test_tools/create_integration_test_ami.py
Outdated
Show resolved
Hide resolved
plugins/hydra_ray_launcher/integration_test_tools/setup_integration_test_ami.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Omry Yadan <omry@yadan.net>
Co-authored-by: Omry Yadan <omry@yadan.net>
Co-authored-by: Omry Yadan <omry@yadan.net>
Jasha10
approved these changes
Jul 16, 2024
|
Thank you @jesszzzz and @crassirostris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make all the CI tests passing (or at least not failing). This involves
# nosec B605to bypass). Also added very basic, non-exhaustive checking to avoid common ways that injection can happenClientErroris thrown (which is currently happening because the AWS cluster has been shut down)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
No CI tests failed on this branch
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)