Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: type annotation in completion_plugin.py #2694

Merged
merged 1 commit into from
Jul 2, 2023
Merged

lint: type annotation in completion_plugin.py #2694

merged 1 commit into from
Jul 2, 2023

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Jun 25, 2023

Closes #2693.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2023
@shagunsodhani shagunsodhani self-requested a review July 2, 2023 18:24
@shagunsodhani shagunsodhani merged commit f5ef687 into facebookresearch:main Jul 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odelalleau odelalleau odelalleau approved these changes

@shagunsodhani shagunsodhani shagunsodhani approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Failing lint: Need type annotation for "matches"
4 participants
@Jasha10 @odelalleau @shagunsodhani @facebook-github-bot