Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shader support and configuration #319

Closed
aclegg3 opened this issue Oct 22, 2019 · 0 comments
Closed

Improve shader support and configuration #319

aclegg3 opened this issue Oct 22, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@aclegg3
Copy link
Contributor

aclegg3 commented Oct 22, 2019

Shader support:

Habitat currently supports flat shading and vertex colored rendering of scenes and objects assuming that lighting is baked into object textures. Many scene and object datasets do not include lighting information in their color, texture, and/or material and are therefore not rendered realistically under this assumption.

Supporting shaders with illumination models will allow such assets to be rendered as intended and greatly increase overall asset compatibility and user experience.

Shader Configuration:

Habitat sim presently relies on automatic parsing of asset features (such as filetype and the presence of materials/textures) to select shaders for rendering scenes and objects. With improved shader support, automation becomes more likely to fail as the number of diverging use cases increases. In addition to shader type, users may prefer to manually configure shader parameters such as light position, intensity, color, relative coordinate frame, etc...

Supporting programmatically configurable shader setups would alleviate issues caused by incorrect shader configurations computed automatically. It would also provide greater support for use cases involving domain randomization, dynamic scene generation, and/or unknown/untested datasets.

Short list of desired features:

  • Support for Magnum Phong illumination shader
  • Programatic configuration of shader parameters
  • Configurable assignment of scenes/objects to shader groups (to override automatic assignment)
@aclegg3 aclegg3 added the enhancement New feature or request label Oct 22, 2019
@aclegg3 aclegg3 self-assigned this Oct 22, 2019
@matthewjmay matthewjmay self-assigned this Jan 27, 2020
@aclegg3 aclegg3 closed this as completed Jul 7, 2020
eundersander pushed a commit to eundersander/habitat-sim that referenced this issue Aug 6, 2020
* Habitat challenge 2020 remote evaluation

* Timeout and env docker

* Correctly update obs

* Use os env variable for address, port

* isort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants