-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for h5py memory leak #227
Conversation
Hi @soumickmj! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @soumickmj, the copy()
commands threw an error for me because h5py
datasets don't have the copy()
command. You need to convert to a numpy array first.
I tried modifying the PR to convert to a numpy array prior to copy()
commands and it didn't for me with the memory issue - I still observed exploding memory. This also included a case where I applied a deepcopy()
to the dict
.
@@ -345,11 +345,11 @@ def __getitem__(self, i: int): | |||
fname, dataslice, metadata = self.examples[i] | |||
|
|||
with h5py.File(fname, "r") as hf: | |||
kspace = hf["kspace"][dataslice] | |||
kspace = hf["kspace"][dataslice].copy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throws an error.
|
||
mask = np.asarray(hf["mask"]) if "mask" in hf else None | ||
mask = np.asarray(hf["mask"].copy()) if "mask" in hf else None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throws an error.
|
||
target = hf[self.recons_key][dataslice] if self.recons_key in hf else None | ||
target = hf[self.recons_key][dataslice].copy() if self.recons_key in hf else None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throws an error.
Hi @mmuckley Converting to numpy explicitly and then copy: I tried earlier and that did not resolve the issue for me as well. I wonder what's the difference then. |
This is the full error:
So the issue might be that you're calling it on the test set and returning We actually have a unit test for |
Closing due to inactivity. |
No description provided.