-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faiss compatibility with NumPy 2 (ImportError: numpy.core.multiarray failed to import) #3526
Comments
Also see this in |
hi @ydshieh, thank you for flagging. Just checking, if you installed faiss with pip, we don't support installation with pip. Could you try installing faiss with conda as per INSTALL.md and let us know if there are still issues? |
Hi @mlomeli1 Our currently CI environment doesn't have Is there a plan to support numpy 2.0.0 (and ideally with pip install)? |
@mlomeli1 thanks, I didn't know that, sorry about that. Unfortunately, if I use conda, it fetches numpy 1.26.4 and numpy-base 1.26.4:
Then I can't install numpy 2.0 because of version conflicts:
@ydshieh There's an open issue already in |
I have always used pip + venv. This combination has always worked well. |
@pdarulewski But #104 and #105 mean, as long as we need to use faiss, we can't use numpy v2. I don't feel strong, but maybe at some point it's nice to make them compatible. |
Heads up, it looks like faiss + numpy2.0 using conda installation is also not behaving as expected from https://github.com/facebookresearch/faiss/actions/runs/10117066685/job/27981278918?pr=3696 I will take a look |
Mark it. |
Summary
I'm not really sure if this is something on my side or Faiss but from the logs it looks like Faiss needs to be recompiled with the newest NumPy release. AFAIK, there are a couple of C API changes: https://numpy.org/doc/stable/release/2.0.0-notes.html
Platform
OS: macOS 14.4.1 23E224 arm64
Faiss version: faiss-cpu==1.8.0
Installed from: pypi through poetry and pip
Faiss compilation options: none
Running on:
Interface:
Reproduction instructions
To reproduce:
The text was updated successfully, but these errors were encountered: