Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oss doc #101

Merged
merged 6 commits into from
Sep 22, 2020
Merged

Oss doc #101

merged 6 commits into from
Sep 22, 2020

Conversation

blefaudeux
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Moving #63 to the right direction, hopefully.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2020
@blefaudeux
Copy link
Contributor Author

note: I resurrected an old branch for that, and did not realize that the old commits would show up here

Copy link
Contributor

@msbaines msbaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs stuff looks OK. Can you rebase or merge with master to avoid extraneous diffs due to changes to benchmarks/oss.py

@blefaudeux blefaudeux merged commit d80c38f into master Sep 22, 2020
@blefaudeux blefaudeux deleted the oss_doc branch September 22, 2020 16:54
@blefaudeux
Copy link
Contributor Author

@msbaines the benchmark changes were on purpose actually, fixing the broken all_reduce/loss.backward() + minor readability. I hope that works for you, landed to get some of the API documentation up ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants