minor fixes for 4.1.0a1 #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
print out the exception when calling callback ensures all threads can be stopped when interrupting separation add release data for 4.0.1
facebook-github-bot
added
the
CLA Signed
adefossez
suggested changes
Oct 13, 2023
adefossez
suggested changes
Oct 16, 2023
adefossez
suggested changes
Oct 18, 2023
adefossez
approved these changes
Nov 16, 2023
|
it seemed 4.1.0a1 is not released in pip? |
|
Beta versions will not be pushed to pip to avoid instability. You can install it using git repo. |
adefossez
added a commit
to adefossez/demucs
that referenced
this pull request
Dec 21, 2023
* Update README.md * Update README.md * Update README.md * Update README.md * minor fixes for 4.1.0a1 (facebookresearch#552) * minor fixes for 4.1.0a1 print out the exception when calling callback ensures all threads can be stopped when interrupting separation add release data for 4.0.1 * Fix model_idx_in_bag always zero * fix linter * Fix can't separate empty audio * Calls callback when skipping empty audio * Add description for aborting * Does not ignore callback exception * Fix linter * Does not ignore exception * Disable torchaudio 2.2+ * Uses epsilon to deal with empty audio * Reraises exception in callback * Ensure the pool stops when encountering exception * Update windows.md for latest instructions * Minor documentation updates (facebookresearch#565) * Minor documentation updates * Update readme * Update api.md * Fix segment defined in bag can't override model * merge from adefossez/demucs * Update README.md --------- Co-authored-by: Alexandre Défossez <adefossez@users.noreply.github.com> Co-authored-by: William Dye <will2dye4@mac.com>
adefossez
added a commit
to adefossez/demucs
that referenced
this pull request
Jan 12, 2024
* Update README.md * Update README.md * Update README.md * Update README.md * minor fixes for 4.1.0a1 (facebookresearch#552) * minor fixes for 4.1.0a1 print out the exception when calling callback ensures all threads can be stopped when interrupting separation add release data for 4.0.1 * Fix model_idx_in_bag always zero * fix linter * Fix can't separate empty audio * Calls callback when skipping empty audio * Add description for aborting * Does not ignore callback exception * Fix linter * Does not ignore exception * Disable torchaudio 2.2+ * Uses epsilon to deal with empty audio * Reraises exception in callback * Ensure the pool stops when encountering exception * Update windows.md for latest instructions * Minor documentation updates (facebookresearch#565) * Minor documentation updates * Update readme * Update api.md * Fix segment defined in bag can't override model * merge from adefossez/demucs * Update README.md * Extend torchaudio support to 2.1.x * Use correct import statement * Calculate FFT on CPU also when device is XPU (Intel GPU) --------- Co-authored-by: Alexandre Défossez <adefossez@users.noreply.github.com> Co-authored-by: William Dye <will2dye4@mac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have a suggestion: trying all decoders of torchaudio before falling back to ffmpeg (torchaudio 2.1.0 will support ffmpeg backend itself so maybe reading with ffmpeg can be removed?)
Changes