Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs - 4.1.0a1 #499

Merged
merged 48 commits into from
Sep 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
0517243
Allow manually run workflow
CarlGao4 May 10, 2023
0b55014
Add HTDemucs to AnyModel
CarlGao4 May 10, 2023
241ce88
Set minimum Python version to 3.8
CarlGao4 May 10, 2023
7434ce7
Add type hints for save_audio
CarlGao4 May 10, 2023
2e44697
Update segment machenism
CarlGao4 May 10, 2023
eced443
Update help message that htdemucs is the default
CarlGao4 May 10, 2023
e292512
Add segment test
CarlGao4 May 10, 2023
df5fb96
Fix linter
CarlGao4 May 10, 2023
8e42a11
API
CarlGao4 May 10, 2023
1b844c3
Update separate.py to use api
CarlGao4 May 10, 2023
166ed8e
Version 4.1.0a1
CarlGao4 May 10, 2023
2c47857
Update api.md
CarlGao4 May 10, 2023
6c8523a
Make parameter `repo` clearer
CarlGao4 May 19, 2023
cc9fdd6
Add doc for loading existing audio in quick start
CarlGao4 May 19, 2023
29d6bfd
Fix typo in docs
CarlGao4 May 19, 2023
a3bc05d
Add flac output
CarlGao4 May 19, 2023
bfdb0f2
Fix linter
CarlGao4 May 19, 2023
2801a90
Merge branch 'main' into 4.0.1a1
CarlGao4 May 24, 2023
a02c866
Fix conflicts
CarlGao4 May 24, 2023
6dbc3f8
Fix wrong indent
CarlGao4 May 24, 2023
b0dc401
import htdemucs
CarlGao4 May 24, 2023
626729d
import htdemucs
CarlGao4 May 24, 2023
f6d61c1
rename variable
CarlGao4 May 24, 2023
b082f52
Fix variable name
CarlGao4 May 24, 2023
436ba3d
Fix mypy linting
CarlGao4 May 24, 2023
94c4bcb
Fix mypy linting again
CarlGao4 May 24, 2023
e19f270
flac output & max_allowed_segment only for HTDemucs
CarlGao4 May 24, 2023
b1abd68
Check max_allowed_segment inside API
CarlGao4 May 24, 2023
ace733d
Fix codes forgot to change
CarlGao4 May 24, 2023
7aa4465
Merge branch 'main' into 4.1.0a1
CarlGao4 May 24, 2023
4d6255a
Update release.md
CarlGao4 May 27, 2023
a97fb8e
Use in-place operation to save memory
CarlGao4 May 27, 2023
b816810
fix linter
CarlGao4 May 27, 2023
475eb90
Make API simpler
CarlGao4 Jun 15, 2023
543d141
Merge branch '4.1.0a1' of https://github.com/CarlGao4/demucs into 4.1…
CarlGao4 Jun 15, 2023
26ca122
Merge branch 'main' into 4.1.0a1
CarlGao4 Jun 15, 2023
085df79
Optimise code and fix separate api returns different wave
CarlGao4 Jun 17, 2023
b432ede
Fixes according to review
CarlGao4 Jun 25, 2023
839089b
Allow changing remote_root when listing models
CarlGao4 Jul 25, 2023
0f1f45c
revert changes
CarlGao4 Jul 25, 2023
7779789
return file path for list_models
CarlGao4 Jul 25, 2023
21855b5
fix Typing
CarlGao4 Jul 25, 2023
9bcf7d0
Merge branch 'main' into 4.1.0a1
CarlGao4 Aug 4, 2023
9957e2c
Minor fixes with linter
CarlGao4 Aug 4, 2023
576a5a5
Fix lock; use `KeyboardInterrupt` to abort
CarlGao4 Sep 21, 2023
2be8e11
Fix Linter
CarlGao4 Sep 21, 2023
f789ca3
Update doc
CarlGao4 Sep 22, 2023
733cb25
List model argument
CarlGao4 Sep 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ Session.vim
/trash
/misc
/mdx
.mypy_cache
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ test_eval:
python3 -m demucs -n demucs_unittest --flac --int24 test.mp3
python3 -m demucs -n demucs_unittest --int24 --clip-mode clamp test.mp3
python3 -m demucs -n demucs_unittest --segment 8 test.mp3
python3 -m demucs.api -n demucs_unittest --segment 8 test.mp3
python3 -m demucs --list-models

tests/musdb:
test -e tests || mkdir tests
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ import shlex
demucs.separate.main(shlex.split('--mp3 --two-stems vocals -n mdx_extra "track with space.mp3"'))
```

To use more complicated APIs, see [API docs](docs/api.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API should be the preferred way :) The shlex thing is a huge hack. If the API is well done we should totally replace those instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this API can be kept so users can easier separate an audio without learning how the API works inside another program


## Training Demucs

If you want to train (Hybrid) Demucs, please follow the [training doc](docs/training.md).
Expand Down
2 changes: 1 addition & 1 deletion demucs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# This source code is licensed under the license found in the
# LICENSE file in the root directory of this source tree.

__version__ = "4.0.1a3"
__version__ = "4.1.0a1"
Loading
Loading