-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIs - 4.1.0a1 #499
Merged
Merged
APIs - 4.1.0a1 #499
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
0517243
Allow manually run workflow
CarlGao4 0b55014
Add HTDemucs to AnyModel
CarlGao4 241ce88
Set minimum Python version to 3.8
CarlGao4 7434ce7
Add type hints for save_audio
CarlGao4 2e44697
Update segment machenism
CarlGao4 eced443
Update help message that htdemucs is the default
CarlGao4 e292512
Add segment test
CarlGao4 df5fb96
Fix linter
CarlGao4 8e42a11
API
CarlGao4 1b844c3
Update separate.py to use api
CarlGao4 166ed8e
Version 4.1.0a1
CarlGao4 2c47857
Update api.md
CarlGao4 6c8523a
Make parameter `repo` clearer
CarlGao4 cc9fdd6
Add doc for loading existing audio in quick start
CarlGao4 29d6bfd
Fix typo in docs
CarlGao4 a3bc05d
Add flac output
CarlGao4 bfdb0f2
Fix linter
CarlGao4 2801a90
Merge branch 'main' into 4.0.1a1
CarlGao4 a02c866
Fix conflicts
CarlGao4 6dbc3f8
Fix wrong indent
CarlGao4 b0dc401
import htdemucs
CarlGao4 626729d
import htdemucs
CarlGao4 f6d61c1
rename variable
CarlGao4 b082f52
Fix variable name
CarlGao4 436ba3d
Fix mypy linting
CarlGao4 94c4bcb
Fix mypy linting again
CarlGao4 e19f270
flac output & max_allowed_segment only for HTDemucs
CarlGao4 b1abd68
Check max_allowed_segment inside API
CarlGao4 ace733d
Fix codes forgot to change
CarlGao4 7aa4465
Merge branch 'main' into 4.1.0a1
CarlGao4 4d6255a
Update release.md
CarlGao4 a97fb8e
Use in-place operation to save memory
CarlGao4 b816810
fix linter
CarlGao4 475eb90
Make API simpler
CarlGao4 543d141
Merge branch '4.1.0a1' of https://github.com/CarlGao4/demucs into 4.1…
CarlGao4 26ca122
Merge branch 'main' into 4.1.0a1
CarlGao4 085df79
Optimise code and fix separate api returns different wave
CarlGao4 b432ede
Fixes according to review
CarlGao4 839089b
Allow changing remote_root when listing models
CarlGao4 0f1f45c
revert changes
CarlGao4 7779789
return file path for list_models
CarlGao4 21855b5
fix Typing
CarlGao4 9bcf7d0
Merge branch 'main' into 4.1.0a1
CarlGao4 9957e2c
Minor fixes with linter
CarlGao4 576a5a5
Fix lock; use `KeyboardInterrupt` to abort
CarlGao4 2be8e11
Fix Linter
CarlGao4 f789ca3
Update doc
CarlGao4 733cb25
List model argument
CarlGao4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,4 @@ Session.vim | |
/trash | ||
/misc | ||
/mdx | ||
.mypy_cache |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API should be the preferred way :) The
shlex
thing is a huge hack. If the API is well done we should totally replace those instructions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this API can be kept so users can easier separate an audio without learning how the API works inside another program