Switch aepsych select_inducing_points from soon-to-be-deprecated BoTorch function to replacement with equivalent behavior (#235)
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Torch function to replacement with equivalent behavior (facebookresearch#235) Summary: Pull Request resolved: facebookresearch#235 BoTorch `_select_inducing_points` is being deprecated in pytorch/botorch#1652 / D43001106. It is being replaced by more general inducing point allocator functionality; the legacy behavior remains a special case. Reviewed By: Balandat Differential Revision: D43438578 fbshipit-source-id: 0e9945490b3f228b0c2eca584e77bb5f58769023
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43001106 |
|
Absorbed into #240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #235
BoTorch
_select_inducing_pointsis being deprecated in pytorch/botorch#1652 / D43001106. It is being replaced by more general inducing point allocator functionality; the legacy behavior remains a special case.Reviewed By: Balandat
Differential Revision: D43438578