Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Implement fixes for remote evaluation #109

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

Epic-Eric
Copy link
Collaborator

Description

Minor syntax fixes to remote evaluation. Serves as a prequel to the docker feature later on.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 11, 2024
@Epic-Eric Epic-Eric changed the title implement fixes for remote evaluation Fix: Implement fixes for remote evaluation Aug 11, 2024
@xutaima
Copy link
Contributor

xutaima commented Aug 14, 2024

Thank you so much! It looks good to me! We can merge this after resolve the conflicts

@xutaima xutaima merged commit 439c937 into facebookresearch:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants