-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to poetry 1.2, resolving dependency issues #898
Conversation
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 64.63% 64.62% -0.01%
==========================================
Files 108 108
Lines 9320 9318 -2
==========================================
- Hits 6024 6022 -2
Misses 3296 3296
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for setup problems or the tests failing? or both?
NM, just saw the issue addressing this. Thanks for the fix. |
Overview
As titled, this PR upgrades the base version of poetry that the Mephisto project uses to 1.2. It also upgrades our ParlAI peer dependency to
1.7.0
, however in the process drops support forpython 3.7
.Discussion
Does dropping python 3.7 warrant moving to
mephisto 1.1
? I'm not sure where I land on this, though for now I've only bumped to1.0.4
in this PR. @pringshia any thoughts?Resolves #890