Adding more general function with better name #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
While retrying this step, realized that we need `pip install pre-commit` if it is not already installed.
Codecov Report
@@ Coverage Diff @@
## main #893 +/- ##
==========================================
- Coverage 64.63% 64.62% -0.02%
==========================================
Files 108 108
Lines 9320 9320
==========================================
- Hits 6024 6023 -1
- Misses 3296 3297 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@JackUrb not sure what they cypress one is about. Could you give me a hint please? |
|
Hm something strange is happening with the build flow. I'll see if I can reproduce on the other dependency branch I'm working on. |
JackUrb
approved these changes
Aug 31, 2022
I wait for the new changes you had to land and retry after rebasing with that. |
pre-commit install
Removing threadsafety as we already lock connections behind threads
…histo into assign-qual * 'assign-qual' of https://github.com/facebookresearch/Mephisto: lint adding the new function name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have the
direct_soft_block_mturk_workersfunction which is great to assign any qualification to workers, including the soft blocking qualification. The convenience of this often tempts people to use it for any general qualification (example). This sort of use causes confusion and may end up with logical bugs. This patch renamesdirect_soft_block_mturk_workerstodirect_assign_qual_mturk_workers(with minimal changes). To keep the backward compatibility, we still havedirect_soft_block_mturk_workers; but it is just a wrapper around the call todirect_assign_qual_mturk_workers.Test
Used it with assigning allow list qualification in this PR, and it worked well. Checking the final results proved that it assigned the qualification correctly.