Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding OSTYPE if not exists #892

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Finding OSTYPE if not exists #892

merged 3 commits into from
Aug 30, 2022

Conversation

mojtaba-komeili
Copy link
Contributor

While trying to install mephisto metrics, ran into issues with empty OSTYPE env variable. This fixes that by checking it exists.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2022
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of this @mojtaba-komeili!

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #892 (37c44bf) into main (f8bf7b1) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   64.68%   64.31%   -0.38%     
==========================================
  Files         108      108              
  Lines        9320     9269      -51     
==========================================
- Hits         6029     5961      -68     
- Misses       3291     3308      +17     
Impacted Files Coverage Δ
...tractions/architects/channels/websocket_channel.py 67.96% <0.00%> (-8.60%) ⬇️
mephisto/data_model/assignment.py 57.48% <0.00%> (-4.24%) ⬇️
mephisto/operations/hydra_config.py 50.60% <0.00%> (-1.73%) ⬇️
mephisto/abstractions/architect.py 62.85% <0.00%> (-1.04%) ⬇️
...s/remote_procedure/remote_procedure_agent_state.py 38.98% <0.00%> (-1.02%) ⬇️
.../blueprints/parlai_chat/parlai_chat_task_runner.py 24.50% <0.00%> (-0.99%) ⬇️
...to/abstractions/blueprints/mixins/use_gold_unit.py 30.34% <0.00%> (-0.95%) ⬇️
...tractions/blueprints/mixins/onboarding_required.py 73.77% <0.00%> (-0.84%) ⬇️
mephisto/data_model/agent.py 74.25% <0.00%> (-0.83%) ⬇️
...sto/abstractions/providers/mturk/mturk_provider.py 50.00% <0.00%> (-0.69%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mojtaba-komeili mojtaba-komeili merged commit 51a2b1d into main Aug 30, 2022
@mojtaba-komeili mojtaba-komeili changed the title Finding OSTYPE is not exists Finding OSTYPE if not exists Aug 30, 2022
@JackUrb JackUrb deleted the metrics-ostype branch August 30, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants