Update @blueprintjs/core version

[pringshia]

Fixes #827

Upgrades the @blueprintjs/core dependency for cra-template-mephisto-review

Update: Includes a capitalization file import fix as well

Testing

Built a new review app using the updated template. The following was run from the Mephisto root directory:

npx clear-npx-cache # had to do this first in my case: https://stackoverflow.com/a/70358238
npx create-react-app --template file:packages/cra-template-mephisto-review template-test
cd template-test
npm start

[Etesam913]

Built a new review app using the updated template
npx clear-npx-cache # had to do this first in my case: https://stackoverflow.com/a/70358238
npx create-react-app --template file:packages/cra-template-mephisto-review template-test
cd template-test
npm start

In what directory did you run this in?

You might want to add it to the testing section of your pr as well

[Etesam913]

I ran it in my root Mephisto directory and got this:

In browser

In terminal

[pringshia]

In what directory did you run this in?

You might want to add it to the testing section of your pr as well

Good call out. Updated. It was from the Mephisto root directory

[pringshia]

I ran it in my root Mephisto directory and got this:

Hmm, I'm unable to reproduce this. Tried again and seems to works on my end 🤔

[Etesam913]

In CollectionView.jsx this folder name should be capitalized in the path. Weird, I feel like that should create an error for you as well ...

[Etesam913]

Is is supposed to have this red banner at the bottom?

[pringshia]

In CollectionView.jsx this folder name should be capitalized in the path. Weird, I feel like that should create an error for you as well ...

Why would it need to be capitalized? If it's lowercase in both the source code as well as the file system, shouldn't it just work?

The red banner is expected, but not ideal. It could probably be a little bit more informational rather than the generic error handling we have in place here. The reason is that the interface is meant to be loaded with data through the mephisto review command. When you just do npm start you don't invoke it with any data piped in.

[Etesam913]

Mine is capitalized. I deleted the template-test and installed it again and it the Pagination folder is still capitalized.

Maybe @JackUrb should act as the tiebreaker here 😆

[Etesam913]

The folder seems to be capitalized on the main branch: https://github.com/facebookresearch/Mephisto/tree/main/packages/cra-template-mephisto-review/template/src/components

[pringshia]

Yep, since the folder is capitalized on Github that should be the source of truth. I'm not sure why my local Mephisto repo didn't have it as such and was out of sync (git diff also doesn't seem to notify for these cases). I've updated the import to reflect the capitalized folder name.

[Etesam913]

LGTM 👍