Update copyright headers across the codebase #1075
Conversation
facebook-github-bot
added
the
CLA Signed
meta-paul
force-pushed
the
add-copyright-headers
branch
6 times, most recently
from
d417b79 to
17bae13
Compare
meta-paul
force-pushed
the
add-copyright-headers
branch
4 times, most recently
from
83f153c to
9d9bdc0
Compare
meta-paul
force-pushed
the
add-copyright-headers
branch
from
9d9bdc0 to
deb096d
Compare
| anchor_line_number = -2 | ||
| for i, line in enumerate(lines[:EXAMINED_LINES]): | ||
| text = line[:50].lower() | ||
| if "copyright" in text: |
There was a problem hiding this comment.
Why do we need this branch, could we merge it with the next one?
There was a problem hiding this comment.
Updating copyright is a different task from creating review app, or other tasks within release v1.2, so I've decided to create a separate branch. In addition, it has a large diff, and resolving potential conflicts is easier from a separate branch.
scripts/update_copyright_headers.py
Outdated
| text = line[:50].lower() | ||
| if "copyright" in text: | ||
| anchor_line_number = -1 | ||
| if anchor_line_number == -1 and ("meta" in text or "facebook" in text): |
There was a problem hiding this comment.
Could it be "copyright" in text instead of anchor_line_number == -1 and removing the above line?
There was a problem hiding this comment.
Agree, this logic could be written better (I abused integer line counter by using it as a status variable). Will push an update.
|
Is that possible to fix the tests, maybe in a follow up PR? |
|
Unittests are broken here (not because copyright script broke the code, but rather it's been a long-standing issue). They will be fixed in a separate branch, and it's not an easy task. |
meta-paul
force-pushed
the
add-copyright-headers
branch
from
23e8461 to
aa2ddb2
Compare
meta-paul
force-pushed
the
add-copyright-headers
branch
from
aa2ddb2 to
e04a812
Compare
This PR comprises a script to auto-update copyright headers
scripts/update_copyright_headers.py, its output, and a few other manual changes.