Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Move loop unroller passes into anonymous namespace. #523

Merged

Conversation

ChrisCummins
Copy link
Contributor

This appears to be the way that the LLVM sources structure their
passes, with the implementation in an anonymous namespace and the
INITIALIZE_PASS_xxx macros in no namespace.

Fixes #509.

This appears to be the way that the LLVM sources structure their
passes, with the implementation in an anonymous namespace and the
INITIALIZE_PASS_xxx macros in no namespace.

Fixes facebookresearch#509.
@ChrisCummins ChrisCummins added this to the v0.2.2 milestone Dec 21, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #523 (95b6e0f) into development (398b39f) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #523      +/-   ##
===============================================
- Coverage        87.38%   87.06%   -0.32%     
===============================================
  Files              113      113              
  Lines             6411     6411              
===============================================
- Hits              5602     5582      -20     
- Misses             809      829      +20     
Impacted Files Coverage Δ
compiler_gym/views/observation.py 97.29% <0.00%> (-2.71%) ⬇️
compiler_gym/envs/compiler_env.py 87.32% <0.00%> (-2.16%) ⬇️
compiler_gym/envs/llvm/compute_observation.py 87.50% <0.00%> (-2.09%) ⬇️
compiler_gym/util/runfiles_path.py 89.28% <0.00%> (-1.79%) ⬇️
compiler_gym/service/connection.py 75.67% <0.00%> (-1.36%) ⬇️
compiler_gym/views/observation_space_spec.py 90.52% <0.00%> (-1.06%) ⬇️
compiler_gym/envs/llvm/llvm_benchmark.py 89.92% <0.00%> (-0.78%) ⬇️
compiler_gym/datasets/dataset.py 84.96% <0.00%> (-0.76%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 88.59% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398b39f...95b6e0f. Read the comment docs.

Copy link
Contributor

@mostafaelhoushi mostafaelhoushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisCummins ChrisCummins merged commit 8611c25 into facebookresearch:development Dec 23, 2021
@ChrisCummins ChrisCummins deleted the loop-unroller-build branch December 23, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[examples] "explicit qualification in declaration" while building loop_unroller example
4 participants