Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Port the explore script to the new wrappers classes. #285

Merged
merged 1 commit into from
Jun 3, 2021
Merged

[examples] Port the explore script to the new wrappers classes. #285

merged 1 commit into from
Jun 3, 2021

Conversation

ChrisCummins
Copy link
Contributor

@ChrisCummins ChrisCummins commented May 28, 2021 •
edited
Loading

Use the newConstrainedCommandline environment wrapper rather than defining a custom environment. This is the same refactor as in fa6877d applied to the exploration script.

@ChrisCummins
[examples] Port the explor script to the new wrappers classes.
b618d23 
Same refactor as in:

    commit fa6877d
    Date:   Tue May 18 03:01:01 2021 +0100
    [examples] Update Actor Critic to use the new wrappers classes.

applied to the exploration script.
@ChrisCummins ChrisCummins requested a review from broune May 28, 2021 10:45
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #285 (b618d23) into development (9ab1b04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #285   +/-   ##
============================================
  Coverage        82.42%   82.42%           
============================================
  Files               87       87           
  Lines             4729     4729           
============================================
  Hits              3898     3898           
  Misses             831      831

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab1b04...b618d23. Read the comment docs.

@ChrisCummins ChrisCummins changed the title [examples] Port the explor script to the new wrappers classes. [examples] Port the explore script to the new wrappers classes. Jun 3, 2021
@ChrisCummins ChrisCummins merged commit 0926f15 into development Jun 3, 2021
@ChrisCummins ChrisCummins deleted the custom-env branch June 3, 2021 13:51
broune
broune reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@broune broune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(I'm a little bit skeptical of ".n" as meaning "count" or "number of", but that pre-existing concept isn't being introduced here, so that's orthogonal.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broune broune broune left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisCummins @codecov-commenter @broune @facebook-github-bot