Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] GNN #30

Merged
merged 13 commits into from
Nov 27, 2023
Merged

[Model] GNN #30

merged 13 commits into from
Nov 27, 2023

Conversation

matteobettini
Copy link
Collaborator

@matteobettini matteobettini commented Oct 20, 2023

This PR aims at introducing a GNN model customizable via torch_geometric.

This is currently on hold because of:

pytorch/rl#1576

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2023
@matteobettini matteobettini added the smacv2 Label to be assigned to run the SMACv2 tests label Oct 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (c6114e0) 89.47% compared to head (935e49e) 45.26%.
Report is 2 commits behind head on main.

Files Patch % Lines
benchmarl/models/gnn.py 34.56% 53 Missing ⚠️
test/test_pettingzoo.py 62.50% 3 Missing ⚠️
test/test_smacv2.py 57.14% 3 Missing ⚠️
test/test_vmas.py 57.14% 3 Missing ⚠️
test/conftest.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #30       +/-   ##
===========================================
- Coverage   89.47%   45.26%   -44.21%     
===========================================
  Files          54       56        +2     
  Lines        2451     2556      +105     
===========================================
- Hits         2193     1157     -1036     
- Misses        258     1399     +1141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini marked this pull request as ready for review November 27, 2023 14:15
@matteobettini
Copy link
Collaborator Author

@janblumenkamp @Acciorocketships here is the GNN!

@matteobettini matteobettini merged commit ee12a28 into main Nov 27, 2023
12 checks passed
@matteobettini matteobettini deleted the gnn branch November 27, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. smacv2 Label to be assigned to run the SMACv2 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants