Skip to content

Commit

Permalink
Fix Video Unit Tests (#248)
Browse files Browse the repository at this point in the history
Summary:

A reason our OSS repo tests are failing is because on OSS our vidgear dependency was on v0.3.2 and we were on v0.2.4

They changed the `output_filename` parameter to be `output` between these versions, so updating our code

Reviewed By: mayaliliya

Differential Revision: D50663349
  • Loading branch information
jbitton authored and facebook-github-bot committed Oct 26, 2023
1 parent aa42202 commit ef9738f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion augly/audio/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ librosa>=0.8.1
numpy>=1.19.5
SoundFile>=0.10.3.post1
torch>=1.9.0
torchaudio>=0.9.0
torchaudio==2.0.2
2 changes: 1 addition & 1 deletion augly/video/augmenters/ffmpeg/base_augmenter.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def add_augmenter(
if video_path == output_path:
shutil.copyfile(video_path, tmpfile.name)
video_path = tmpfile.name
writer = WriteGear(output_filename=output_path, logging=True)
writer = WriteGear(output=output_path, logging=True)
writer.execute_ffmpeg_cmd(self.get_command(video_path, output_path))
writer.close()

Expand Down
2 changes: 1 addition & 1 deletion augly/video/helpers/ffmpeg.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def combine_frames_and_audio_to_file(


def execute_vidgear_command(output_path: str, ffmpeg_command: List[str]) -> None:
writer = WriteGear(output_filename=output_path, logging=True)
writer = WriteGear(output=output_path, logging=True)
writer.execute_ffmpeg_cmd(ffmpeg_command)
writer.close()

Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ dataclasses-json>=0.5.2
iopath>=0.1.8
python-magic>=0.4.22
regex>=2021.4.4
setuptools>=65.5.1

0 comments on commit ef9738f

Please sign in to comment.