Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of VELOX_BUILD_MINIMAL_WITH_DWIO flag #9576

Closed
wants to merge 1 commit into from

Conversation

pedroerp
Copy link
Contributor

Summary:
Fixing the intended behavior of the open source compilation flag
VELOX_BUILD_MINIMAL_WITH_DWIO, which is to compile VELOX_BUILD_MINIMAL, plus
dwio.

Differential Revision: D56453924

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56453924

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 99ee3df
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66273b32b1ab360008680e57

…#9576)

Summary:

Fixing the intended behavior of the open source compilation flag
VELOX_BUILD_MINIMAL_WITH_DWIO, which is to compile VELOX_BUILD_MINIMAL, plus
dwio.

Differential Revision: D56453924
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56453924

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedroerp LGTM. Thanks!

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ba8253b.

Copy link

Conbench analyzed the 1 benchmark run on commit ba8253be.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
…#9576)

Summary:
Pull Request resolved: facebookincubator#9576

Fixing the intended behavior of the open source compilation flag
VELOX_BUILD_MINIMAL_WITH_DWIO, which is to compile VELOX_BUILD_MINIMAL, plus
dwio.

Reviewed By: xiaoxmeng

Differential Revision: D56453924

fbshipit-source-id: 11effdd7062ac3ca3dd440e958eb7490ff263b44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants