-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behavior of VELOX_BUILD_MINIMAL_WITH_DWIO flag #9576
Conversation
This pull request was exported from Phabricator. Differential Revision: D56453924 |
✅ Deploy Preview for meta-velox canceled.
|
…#9576) Summary: Fixing the intended behavior of the open source compilation flag VELOX_BUILD_MINIMAL_WITH_DWIO, which is to compile VELOX_BUILD_MINIMAL, plus dwio. Differential Revision: D56453924
7e75ea8
to
99ee3df
Compare
This pull request was exported from Phabricator. Differential Revision: D56453924 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedroerp LGTM. Thanks!
This pull request has been merged in ba8253b. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…#9576) Summary: Pull Request resolved: facebookincubator#9576 Fixing the intended behavior of the open source compilation flag VELOX_BUILD_MINIMAL_WITH_DWIO, which is to compile VELOX_BUILD_MINIMAL, plus dwio. Reviewed By: xiaoxmeng Differential Revision: D56453924 fbshipit-source-id: 11effdd7062ac3ca3dd440e958eb7490ff263b44
Summary:
Fixing the intended behavior of the open source compilation flag
VELOX_BUILD_MINIMAL_WITH_DWIO, which is to compile VELOX_BUILD_MINIMAL, plus
dwio.
Differential Revision: D56453924