Add GCS dependencies to resolve_dependency and refactor cmake modules #9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
tigrux
force-pushed
the
gcs_bigquery_deps
branch
from
d7b4b56
to
5981121
Compare
tigrux
force-pushed
the
gcs_bigquery_deps
branch
2 times, most recently
from
d4290b5
to
e44984c
Compare
tigrux
force-pushed
the
gcs_bigquery_deps
branch
24 times, most recently
from
d6000d3
to
4a97c3a
Compare
|
Once #9861 is merged you can remove the install bits in the workflows and rebase on it (you'll have to wait a bit after the merge for the rebuild of the containers). I'll review after that but looks good so far, thanks for the contribution! :) |
|
Hello @majetideepak, @assignUser, @kgpai, @pedroerp, @bdice. |
assignUser
approved these changes
May 24, 2024
There was a problem hiding this comment.
Looks good thanks! As the docker images have been updated you can remove the steps where you installed the recent cmake in #9861.
CMake/resolve_dependency_modules/google_cloud_cpp_storage.cmake
Outdated
Show resolved
Hide resolved
Closed
tigrux
force-pushed
the
gcs_bigquery_deps
branch
2 times, most recently
from
0c19873
to
70dbbd6
Compare
assignUser
changed the title
assignUser
approved these changes
May 24, 2024
assignUser
added
the
ready-to-merge
bdice
approved these changes
May 24, 2024
tigrux
force-pushed
the
gcs_bigquery_deps
branch
3 times, most recently
from
1ee4549
to
2225f63
Compare
assignUser
added
ready-to-merge
kgpai
approved these changes
May 28, 2024
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
The new features in cmake 3.28 allow the cmake modules to be simplified.
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…facebookincubator#9072) Summary: The goal of this change is to refactor and simplify the existing cmake modules. Pull Request resolved: facebookincubator#9072 Reviewed By: bikramSingh91 Differential Revision: D57883357 Pulled By: kgpai fbshipit-source-id: e7f95330e11be652b8c343a8743434df9d59bd76
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…facebookincubator#9072) Summary: The goal of this change is to refactor and simplify the existing cmake modules. Pull Request resolved: facebookincubator#9072 Reviewed By: bikramSingh91 Differential Revision: D57883357 Pulled By: kgpai fbshipit-source-id: e7f95330e11be652b8c343a8743434df9d59bd76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to refactor and simplify the existing cmake modules.