Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array_sort Presto function when evaluating a subset of rows #7800

Closed
wants to merge 1 commit into from
Closed

Fix array_sort Presto function when evaluating a subset of rows #7800

wants to merge 1 commit into from

Conversation

mbasmanova
Copy link
Contributor

array_sort used to generate invalid dictionary vectors when evaluating only a subset of rows:

VeloxRuntimeError: dictionaryIndices->size() >= length * sizeof(vector_size_t) (36 vs. 40) Malformed dictionary, index array is shorter than DictionaryVector

@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 095d756
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6567ef3d89dbe90008fa4c7a

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 30, 2023
@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng
xiaoxmeng approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbasmanova thanks for the fix!

amitkdutta
amitkdutta approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in 1231555.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 12315553.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkdutta amitkdutta amitkdutta approved these changes

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbasmanova @facebook-github-bot @amitkdutta @xiaoxmeng