Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RowTypePtr in QueryAssertions.* #7607

Closed
wants to merge 1 commit into from

Conversation

mbasmanova
Copy link
Contributor

No description provided.

@mbasmanova mbasmanova marked this pull request as ready for review November 16, 2023 17:20
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2023
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 7ddc645
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65564f6e2c93330008c716c5

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbasmanova LGTM. Thanks!

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbasmanova

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in cc967f4.

Copy link

Conbench analyzed the 1 benchmark run on commit cc967f4e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants