save some CI diskspace, use ubuntu 20.04 and later libgit2 #6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49874384 |
Summary: fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 583fe369aa34940dd6ae7f74d603d7a16fe45793
Summary: allow getdeps github actions to free up disk Allow getdeps to free up some disk from the runner and intermediate build steps as some runs (notably the linux eden and mononoke ones) are hitting disk space limits X-link: facebook/sapling#689 Differential Revision: D49875256 Pulled By: genevievehelsel fbshipit-source-id: 00cba89045916de61eaccd81a22f3750a5220e18
Summary: fix getdeps actions generation for rust toolchain Generated actions files created from getdeps.py were missing rust toolchain which meant annoying manual edits This change also makes the github actions generation honor the --no-tests argument, which is useful when regenerating the edenfs actions X-link: facebook/sapling#682 Differential Revision: D49875258 Pulled By: genevievehelsel fbshipit-source-id: 8c5b1727254dd403ef1771a91f68de14cd54b19f
Summary: fix edenfs oss build, ubuntu googletest is too old Update the googletest manifest as ubuntu's LTS packages are too old. 22.10 on looks fine X-link: facebook/sapling#692 Differential Revision: D49874525 Pulled By: genevievehelsel fbshipit-source-id: 8c237310088c55dacb236542970fd2ec3b30e33f
…ncubator#6925) Summary: Pull Request resolved: facebookincubator#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Test Plan: Install deps and build locally with ``` sudo ./build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive eden ... ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` before: we build libgit2 from source after: we use the system library --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/693). * __->__ facebook/sapling#693 * facebook/sapling#696 * facebook/sapling#692 * facebook/sapling#691 * facebook/sapling#682 * facebook/sapling#689 * facebook/sapling#697 * facebook/sapling#706 * facebook/sapling#730 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 7d8905a592844e408d4f0eee1aa28295f25c05c7
|
This pull request was exported from Phabricator. Differential Revision: D49874384 |
genevievehelsel
force-pushed
the
export-D49874384
branch
from
ce191da to
5906da5
Compare
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
|
@genevievehelsel merged this pull request in a6daaeb. |
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries Pull Request resolved: #693 Test Plan: Install deps and build locally with ``` sudo ./build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive eden ... ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` before: we build libgit2 from source after: we use the system library --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/693). * __->__ #693 * #696 * #692 * #691 * #682 * #689 * #697 * #706 * #730 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 11, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…ncubator#6925) Summary: Pull Request resolved: facebookincubator#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Test Plan: Install deps and build locally with ``` sudo ./build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive eden ... ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` before: we build libgit2 from source after: we use the system library --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/693). * __->__ facebook/sapling#693 * facebook/sapling#696 * facebook/sapling#692 * facebook/sapling#691 * facebook/sapling#682 * facebook/sapling#689 * facebook/sapling#697 * facebook/sapling#706 * facebook/sapling#730 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 23, 2023
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebookincubator/velox#6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: facebook/sapling#693 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
save some CI diskspace, use ubuntu 20.04 and later libgit2
Save some time and diskspace in CI builds for github by using the system libraries
X-link: facebook/sapling#693
Reviewed By: xavierd
Differential Revision: D49874384
Pulled By: genevievehelsel