fix mononoke linux local cargo build with lld #6923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49875277 |
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 5, 2023
Summary: fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Test Plan: Install the new lld system dep with `sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive mononoke` Run a build locally with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke` Before, zstd link errors like https://github.com/facebook/sapling/actions/runs/5432912652/jobs/9880272333: ``` /usr/bin/ld: /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_sys-837ebc89eb1d31b6.rlib(zstd_lazy.o): in function `ZSTD_compressBlock_btlazy2_extDict': zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): multiple definition of `ZSTD_compressBlock_btlazy2_extDict'; /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_legacy_mononoke_sys-78a66a56bd363eb2.rlib(zstd_lazy.o):zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): first defined here collect2: error: ld returned 1 exit status ``` After, works: ``` Compiling mononoke v0.1.0 (/home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/source/eden/mononoke/server) Finished dev [unoptimized] target(s) in 1m 17s ``` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/697). * facebook/sapling#693 * facebook/sapling#696 * facebook/sapling#692 * facebook/sapling#691 * facebook/sapling#682 * facebook/sapling#689 * __->__ facebook/sapling#697 * facebook/sapling#706 * facebook/sapling#730 Differential Revision: D49875277 Pulled By: genevievehelsel
genevievehelsel
force-pushed
the
export-D49875277
branch
from
62a071b to
33bf894
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49875277 |
Summary: fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Test Plan: Install the new lld system dep with `sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive mononoke` Run a build locally with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke` Before, zstd link errors like https://github.com/facebook/sapling/actions/runs/5432912652/jobs/9880272333: ``` /usr/bin/ld: /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_sys-837ebc89eb1d31b6.rlib(zstd_lazy.o): in function `ZSTD_compressBlock_btlazy2_extDict': zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): multiple definition of `ZSTD_compressBlock_btlazy2_extDict'; /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_legacy_mononoke_sys-78a66a56bd363eb2.rlib(zstd_lazy.o):zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): first defined here collect2: error: ld returned 1 exit status ``` After, works: ``` Compiling mononoke v0.1.0 (/home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/source/eden/mononoke/server) Finished dev [unoptimized] target(s) in 1m 17s ``` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/697). * facebook/sapling#693 * facebook/sapling#696 * facebook/sapling#692 * facebook/sapling#691 * facebook/sapling#682 * facebook/sapling#689 * __->__ facebook/sapling#697 * facebook/sapling#706 * facebook/sapling#730 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel
genevievehelsel
force-pushed
the
export-D49875277
branch
from
33bf894 to
16ba2b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49875277 |
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
|
@genevievehelsel merged this pull request in 8490c1b. |
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 7, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace Pull Request resolved: #697 Test Plan: Install the new lld system dep with `sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive mononoke` Run a build locally with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke` Before, zstd link errors like https://github.com/facebook/sapling/actions/runs/5432912652/jobs/9880272333: ``` /usr/bin/ld: /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_sys-837ebc89eb1d31b6.rlib(zstd_lazy.o): in function `ZSTD_compressBlock_btlazy2_extDict': zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): multiple definition of `ZSTD_compressBlock_btlazy2_extDict'; /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_legacy_mononoke_sys-78a66a56bd363eb2.rlib(zstd_lazy.o):zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): first defined here collect2: error: ld returned 1 exit status ``` After, works: ``` Compiling mononoke v0.1.0 (/home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/source/eden/mononoke/server) Finished dev [unoptimized] target(s) in 1m 17s ``` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/697). * #693 * #696 * #692 * #691 * #682 * #689 * __->__ #697 * #706 * #730 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 11, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebookincubator#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Test Plan: Install the new lld system dep with `sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive mononoke` Run a build locally with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke` Before, zstd link errors like https://github.com/facebook/sapling/actions/runs/5432912652/jobs/9880272333: ``` /usr/bin/ld: /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_sys-837ebc89eb1d31b6.rlib(zstd_lazy.o): in function `ZSTD_compressBlock_btlazy2_extDict': zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): multiple definition of `ZSTD_compressBlock_btlazy2_extDict'; /home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/debug/deps/libzstd_legacy_mononoke_sys-78a66a56bd363eb2.rlib(zstd_lazy.o):zstd_lazy.c:(.text.ZSTD_compressBlock_btlazy2_extDict+0x0): first defined here collect2: error: ld returned 1 exit status ``` After, works: ``` Compiling mononoke v0.1.0 (/home/alex/local/tmp/toolbox/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/mononoke/source/eden/mononoke/server) Finished dev [unoptimized] target(s) in 1m 17s ``` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/697). * facebook/sapling#693 * facebook/sapling#696 * facebook/sapling#692 * facebook/sapling#691 * facebook/sapling#682 * facebook/sapling#689 * __->__ facebook/sapling#697 * facebook/sapling#706 * facebook/sapling#730 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 23, 2023
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebookincubator/velox#6923 fix mononoke linux local cargo build with lld During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking. To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace X-link: facebook/sapling#697 Reviewed By: sggutier Differential Revision: D49875277 Pulled By: genevievehelsel fbshipit-source-id: 998f525fd71333b31747d0ad0e0dda3ebe2b0796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fix mononoke linux local cargo build with lld
During my recent reviewstack changes I noticed that mononoke links fine on macOS, but github PRs are failing on linux with duplicate zstd symbols during linking.
To fix this, switch to lld for the final link on linux by setting the cargo options, which needs a getdeps cargo.py change to ensure they aren't overwritten
It works locally but looks like its running our of disk space on github. Next change in stack addresses github CI diskspace
X-link: facebook/sapling#697
Differential Revision: D49875277
Pulled By: genevievehelsel