Fix RowContainer::hash and equals for inputs of type UNKNOWN #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbasmanova
requested review from
kevinwilfong,
bikramSingh91,
laithsakka and
kagamiori
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mbasmanova
changed the title
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bikramSingh91
approved these changes
Sep 18, 2023
…kincubator#6619) Summary: Fixes facebookincubator#6616 Reviewed By: bikramSingh91 Differential Revision: D49385313 Pulled By: mbasmanova
mbasmanova
force-pushed
the
fix-row-containter-unknown
branch
from
7a61c06
to
feaff99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49385313 |
xiaoxmeng
approved these changes
Sep 19, 2023
|
@mbasmanova merged this pull request in 5c454f7. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…kincubator#6619) Summary: Fixes facebookincubator#6616 Pull Request resolved: facebookincubator#6619 Reviewed By: bikramSingh91 Differential Revision: D49385313 Pulled By: mbasmanova fbshipit-source-id: fb16a50ced469791cfab088568829969c2302243
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…kincubator#6619) Summary: Fixes facebookincubator#6616 Pull Request resolved: facebookincubator#6619 Reviewed By: bikramSingh91 Differential Revision: D49385313 Pulled By: mbasmanova fbshipit-source-id: fb16a50ced469791cfab088568829969c2302243
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…kincubator#6619) Summary: Fixes facebookincubator#6616 Pull Request resolved: facebookincubator#6619 Reviewed By: bikramSingh91 Differential Revision: D49385313 Pulled By: mbasmanova fbshipit-source-id: fb16a50ced469791cfab088568829969c2302243
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…kincubator#6619) Summary: Fixes facebookincubator#6616 Pull Request resolved: facebookincubator#6619 Reviewed By: bikramSingh91 Differential Revision: D49385313 Pulled By: mbasmanova fbshipit-source-id: fb16a50ced469791cfab088568829969c2302243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6616