Implement SparkSQL's divide #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30093191 |
Summary: Function registration is moved from FunctionBaseTest's constructor to SetUpTestCase(), which is once-per-process. Differential Revision: D30061756 fbshipit-source-id: 3a8c47e03ee25014c0a68ff8e9e427e158ba5104
Differential Revision: D30092234 fbshipit-source-id: 107fdc127ad15ff26b80c3c40755bb19fc967b8a
Summary: Pull Request resolved: #20 Spark's divide returns NULL when dividing by zero. All other behavior is consistent with IEEE floating point. Differential Revision: D30093191 fbshipit-source-id: 54994d229531641dc2052186e644797d0c13f05c
|
This pull request was exported from Phabricator. Differential Revision: D30093191 |
|
This pull request has been merged in 894d7de. |
zhouyuan
added a commit
to zhouyuan/velox
that referenced
this pull request
Jun 19, 2022
[OPPRO-105] Fix memory pool
This was referenced Oct 8, 2022
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Spark's divide returns NULL when dividing by zero. All other behavior is
consistent with IEEE floating point.
Differential Revision: D30093191