Implement version of unaryminus that allows overflow for Spark (#1339) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30092234 |
Summary: Spark uses a variant of Murmur3; I've copied the hash implementation directly from the Spark codebase, modified of course for C++. The Spark algorithm for combining hashes is simple: initialize the hash to 42, and then use the current hash as the seed for the next hash. NULLs are skipped. This implementation processes one column at a time. Differential Revision: D29743513 fbshipit-source-id: 2784e0959183559bf1bafec59e588a290986aa65
Summary: Function registration is moved from FunctionBaseTest's constructor to SetUpTestCase(), which is once-per-process. Differential Revision: D30061756 fbshipit-source-id: 0ce37ef8a4b0686f70a6fd7395a8b979721672e3
Summary: Pull Request resolved: #19 Pull Request resolved: facebookexternal/f4d#1339 Reviewed By: pedroerp Differential Revision: D30092234 fbshipit-source-id: 3a03cd0660bb39be4f60709818048fc9227cf679
|
This pull request was exported from Phabricator. Differential Revision: D30092234 |
|
This pull request has been merged in 0fbbf0a. |
This was referenced Oct 8, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
* add a fake output for easier debug * fallback the second stage * format
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: https://github.com/facebookexternal/f4d/pull/1339
Reviewed By: pedroerp
Differential Revision: D30092234