Use Operator::finish() instead of setting isFinishing_ flag directly #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 7708357. |
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
May 28, 2022
…r#15) * Fix semi join with extra filter (facebookincubator#1726) Summary: CC: rui-mo Pull Request resolved: facebookincubator#1726 Reviewed By: oerling Differential Revision: D36703403 Pulled By: mbasmanova fbshipit-source-id: a39788e451b544a8830c328950dd87a8bf600847 * Add support for anti join with filter (facebookincubator#1728) Summary: Pull Request resolved: facebookincubator#1728 Reviewed By: oerling Differential Revision: D36706888 Pulled By: mbasmanova fbshipit-source-id: b7d57c9ef42ee674ce26600ddbac93f45a0a4dcc Co-authored-by: Masha Basmanova <mbasmanova@fb.com>
This was referenced Oct 8, 2022
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 23, 2023
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 24, 2023
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.